Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1792D200498 for ; Tue, 29 Aug 2017 15:23:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 15D0E166A0B; Tue, 29 Aug 2017 13:23:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6397F166A09 for ; Tue, 29 Aug 2017 15:23:54 +0200 (CEST) Received: (qmail 61678 invoked by uid 500); 29 Aug 2017 13:23:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61667 invoked by uid 99); 29 Aug 2017 13:23:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 13:23:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 613E1C2B32; Tue, 29 Aug 2017 13:23:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id L5SeX8vqw-Mg; Tue, 29 Aug 2017 13:23:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DCB685FE37; Tue, 29 Aug 2017 13:23:50 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 469EAE0044; Tue, 29 Aug 2017 13:23:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7382BC40476; Tue, 29 Aug 2017 13:23:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0877298102436316913==" MIME-Version: 1.0 Subject: Re: Review Request 58021: Added storage-related offer operations. From: Jan Schlicht To: Benjamin Bannier , Jie Yu Cc: Jan Schlicht , mesos Date: Tue, 29 Aug 2017 13:23:46 -0000 Message-ID: <20170829132346.3355.83291@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58021/ X-Sender: Jan Schlicht References: <20170808082103.27088.61224@reviews-vm2.apache.org> In-Reply-To: <20170808082103.27088.61224@reviews-vm2.apache.org> Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos archived-at: Tue, 29 Aug 2017 13:23:55 -0000 --===============0877298102436316913== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/ ----------------------------------------------------------- (Updated Aug. 29, 2017, 3:23 p.m.) Review request for mesos, Benjamin Bannier and Jie Yu. Changes ------- Addressed issues. Bugs: MESOS-7314 https://issues.apache.org/jira/browse/MESOS-7314 Repository: mesos Description ------- Added storage-related offer operations. Diffs (updated) ----- include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 src/master/master.cpp 183f53070848853b50bfb02bcd6b458ac0b2f685 src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 Diff: https://reviews.apache.org/r/58021/diff/6/ Changes: https://reviews.apache.org/r/58021/diff/5-6/ Testing ------- make check Thanks, Jan Schlicht --===============0877298102436316913==--