Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A4AF2004F3 for ; Tue, 15 Aug 2017 19:36:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 08E11161658; Tue, 15 Aug 2017 17:36:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E3B9160BF9 for ; Tue, 15 Aug 2017 19:36:39 +0200 (CEST) Received: (qmail 70057 invoked by uid 500); 15 Aug 2017 17:36:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70015 invoked by uid 99); 15 Aug 2017 17:36:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 17:36:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7B450C00E2; Tue, 15 Aug 2017 17:36:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id AAqtt1BK2MfP; Tue, 15 Aug 2017 17:36:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 03AB55FC55; Tue, 15 Aug 2017 17:36:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A658AE002B; Tue, 15 Aug 2017 17:36:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DF223C40476; Tue, 15 Aug 2017 17:36:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4956525923341450440==" MIME-Version: 1.0 Subject: Re: Review Request 61434: Updated health-checks.md to include description of generalized checks. From: Alexander Rukletsov To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone , Greg Mann Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Avinash sridharan , Alexander Rukletsov , mesos Date: Tue, 15 Aug 2017 17:36:28 -0000 Message-ID: <20170815173628.37511.63825@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61434/ X-Sender: Alexander Rukletsov References: <20170811180459.13591.60990@reviews-vm2.apache.org> In-Reply-To: <20170811180459.13591.60990@reviews-vm2.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos archived-at: Tue, 15 Aug 2017 17:36:40 -0000 --===============4956525923341450440== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Aug. 11, 2017, 6:05 p.m., Greg Mann wrote: > > docs/health-checks.md > > Lines 272-278 (patched) > > > > > > Should we also call out here that setting interval_seconds to zero is a really bad idea? Yes, good suggestion. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182718 ----------------------------------------------------------- On Aug. 11, 2017, 12:12 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61434/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 12:12 a.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7349 > https://issues.apache.org/jira/browse/MESOS-7349 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/health-checks.md d0749347d1f9398004e56b03503d655b5fba75f4 > > > Diff: https://reviews.apache.org/r/61434/diff/2/ > > > Testing > ------- > > https://gist.github.com/rukletsov/517a136cb6a0e8b909db30b36b13eded > > Additionally rendered in MacDown. > > > Thanks, > > Alexander Rukletsov > > --===============4956525923341450440==--