Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1F63820049B for ; Mon, 14 Aug 2017 10:45:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1DB81164A05; Mon, 14 Aug 2017 08:45:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 631AA1649F3 for ; Mon, 14 Aug 2017 10:45:25 +0200 (CEST) Received: (qmail 55444 invoked by uid 500); 14 Aug 2017 08:45:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55433 invoked by uid 99); 14 Aug 2017 08:45:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2017 08:45:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4B49818036E; Mon, 14 Aug 2017 08:45:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Qg9znOPvHtAH; Mon, 14 Aug 2017 08:45:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 11FEF5F27D; Mon, 14 Aug 2017 08:45:21 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AD1D4E002B; Mon, 14 Aug 2017 08:45:20 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EB284C4011F; Mon, 14 Aug 2017 08:45:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9127825373900845837==" MIME-Version: 1.0 Subject: Re: Review Request 61597: Fixed linking to `IPHlpAPI` library. From: Mesos Reviewbot Windows To: Jeff Coffler , Joseph Wu Cc: Mesos Reviewbot Windows , Andrew Schwartzmeyer , mesos Date: Mon, 14 Aug 2017 08:45:18 -0000 Message-ID: <20170814084518.56833.64431@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61597/ X-Sender: Mesos Reviewbot Windows References: <20170811232712.13592.14345@reviews-vm2.apache.org> In-Reply-To: <20170811232712.13592.14345@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos archived-at: Mon, 14 Aug 2017 08:45:26 -0000 --===============9127825373900845837== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61597/#review182846 ----------------------------------------------------------- Bad review! Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot Windows On Aug. 11, 2017, 11:27 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61597/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2017, 11:27 p.m.) > > > Review request for mesos, Jeff Coffler and Joseph Wu. > > > Bugs: MESOS-7704 > https://issues.apache.org/jira/browse/MESOS-7704 > > > Repository: mesos > > > Description > ------- > > While the `#pragma comment(lib...)` method works with MSVC, it is > inconsistent with how we link to the rest of the Windows libraries. So > it was deleted and `IPHlpAPI` was added to stout's Windows dependencies. > > Furthermore, the `` header was removed from the individual > files and placed in `windows.hpp` to ensure it is included in the > correct order with respect to the other Windows headers. > > > Diffs > ----- > > 3rdparty/stout/CMakeLists.txt 76b2a67419cb6836b598a0070f26632d4ca048ff > 3rdparty/stout/include/stout/windows.hpp 92db7278aea5cc9b94bec77071b9803f58042624 > 3rdparty/stout/include/stout/windows/ip.hpp 76f23c823662a54162e64160980512b191bb88e8 > 3rdparty/stout/include/stout/windows/mac.hpp 09c4c9626d135705a502b6d148f5b6ba64b688cd > 3rdparty/stout/include/stout/windows/net.hpp 1418b5c981a2286c9ae390d801a8021e3a442f5b > > > Diff: https://reviews.apache.org/r/61597/diff/1/ > > > Testing > ------- > > stout-tests on Windows > > > Thanks, > > Andrew Schwartzmeyer > > --===============9127825373900845837==--