Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2F161200CE9 for ; Sat, 5 Aug 2017 06:41:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2D9E716D920; Sat, 5 Aug 2017 04:41:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 715EE16D913 for ; Sat, 5 Aug 2017 06:41:14 +0200 (CEST) Received: (qmail 98051 invoked by uid 500); 5 Aug 2017 04:41:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 98040 invoked by uid 99); 5 Aug 2017 04:41:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Aug 2017 04:41:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 89BC0C024A; Sat, 5 Aug 2017 04:41:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id XwZNugoTmAU9; Sat, 5 Aug 2017 04:41:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4FC4A5F30C; Sat, 5 Aug 2017 04:41:11 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BAF79E00A3; Sat, 5 Aug 2017 04:41:10 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A8FCDC4068B; Sat, 5 Aug 2017 04:41:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3730713357747096573==" MIME-Version: 1.0 Subject: Re: Review Request 52103: Implemented quota update in `/quota` endpoint. From: Zhitao Li To: Xiaojian Huang , Neil Conway , Alexander Rukletsov Cc: Benjamin Bannier , Zhitao Li , Mesos Reviewbot , mesos Date: Sat, 05 Aug 2017 04:41:10 -0000 Message-ID: <20170805044110.17965.83941@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zhitao Li X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52103/ X-Sender: Zhitao Li References: <20170210075621.31774.59198@reviews.apache.org> In-Reply-To: <20170210075621.31774.59198@reviews.apache.org> Reply-To: Zhitao Li X-ReviewRequest-Repository: mesos archived-at: Sat, 05 Aug 2017 04:41:15 -0000 --===============3730713357747096573== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52103/ ----------------------------------------------------------- (Updated Aug. 5, 2017, 4:41 a.m.) Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway. Changes ------- Implement update through same `POST` method and `setQuota` functions. Summary (updated) ----------------- Implemented quota update in `/quota` endpoint. Bugs: MESOS-4941 https://issues.apache.org/jira/browse/MESOS-4941 Repository: mesos Description (updated) ------- This patch implemented atomic quota update through on the `/quota` endpoint by relaxing existing `setQuota` functions in allocator interface. Changes included: - implementation in hierarchical allocator; - implementation in quota_handler; - some integration tests for updating a quota. More tests around resource rescind and operator API implementation will be sent in later patches. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035 src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 src/master/quota_handler.cpp 26b2dc86fa44dfdf6e0a6c4993c754a6384dd851 src/tests/master_quota_tests.cpp 9d52f767c112abd55ab3f49d172eb6e3caea511b Diff: https://reviews.apache.org/r/52103/diff/6/ Changes: https://reviews.apache.org/r/52103/diff/5-6/ Testing ------- Thanks, Zhitao Li --===============3730713357747096573==--