mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61981: Added unit test for killing the default executor process.
Date Thu, 31 Aug 2017 04:41:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184235
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1386 (patched)
<https://reviews.apache.org/r/61981/#comment260331>

    s/will not have discard/will not be discarded/



src/tests/default_executor_tests.cpp
Lines 1417 (patched)
<https://reviews.apache.org/r/61981/#comment260332>

    This seems to be used only in line 1421, do we really need to create this alias?



src/tests/default_executor_tests.cpp
Lines 1419 (patched)
<https://reviews.apache.org/r/61981/#comment260329>

    This future isn't needed, waiting for `subscribed` bellow should be enough.



src/tests/default_executor_tests.cpp
Lines 1455 (patched)
<https://reviews.apache.org/r/61981/#comment260330>

    This should be an assertion instead of an expectation.


- Gastón Kleiman


On Aug. 30, 2017, 11:45 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 11:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-7926
>     https://issues.apache.org/jira/browse/MESOS-7926
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for killing the default executor process.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1 
> 
> 
> Diff: https://reviews.apache.org/r/61981/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message