mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 61580: Extracted JNI code into a protected function for clarity.
Date Wed, 30 Aug 2017 21:41:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61580/#review184204
-----------------------------------------------------------


Ship it!




Thanks for the cleanup!

- Anand Mazumdar


On Aug. 30, 2017, 2:16 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61580/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 2:16 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7872
>     https://issues.apache.org/jira/browse/MESOS-7872
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411

> 
> 
> Diff: https://reviews.apache.org/r/61580/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> Manual tests using a [modified hello-world framework](https://github.com/mesosphere/dcos-commons/commit/ba60999cc2545f98fb935e114d20727b441286ed)
from DC/OS' SDK.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message