mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61952: Fixed the communication between old masters and new agents.
Date Mon, 28 Aug 2017 18:46:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61952/#review183969
-----------------------------------------------------------



This change LGTM, one small nit below. Could you also verify this fix with a manual upgrade
test - maybe our 'support/test-upgrade.py' script could be used?


src/slave/slave.cpp
Lines 1591-1592 (patched)
<https://reviews.apache.org/r/61952/#comment260008>

    Looks like your linebreak is a bit early here on L1591?


- Greg Mann


On Aug. 28, 2017, 6:31 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61952/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 6:31 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-7922
>     https://issues.apache.org/jira/browse/MESOS-7922
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For re-registration, 1.4 agents used to send the resources in tasks
> and executors to the master in the "post-reservation-refinement" format,
> which is incompatible for pre-1.4 masters. This patch changes the agent
> such that it always downgrades the resources to
> the "pre-reservation-refinement" format, and the master unconditionally
> upgrades the resources to "post-reservation-refinement" format.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp a9d2191d92d0a56c8a137cb28f41a3632db54fe9 
>   src/slave/slave.cpp 3e880b3ad54dbad46f71c335c2a93edb9a546176 
> 
> 
> Diff: https://reviews.apache.org/r/61952/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message