mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 61818: Adjusted a comment and a log message around container termination.
Date Wed, 23 Aug 2017 14:28:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/#review183599
-----------------------------------------------------------



Patch looks great!

Reviews applied: [61811, 59746, 61818]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 22, 2017, 5:18 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61818/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 5:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the container launch is aborted and the container is
> cleaned up in the containerizer before `executorLaunched()` is
> invoked, `containerizer->wait()` called in `executorLaunched()`
> does not hold a termination object. This case should not be
> logged as an error.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a 
> 
> 
> Diff: https://reviews.apache.org/r/61818/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message