mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61538: Used common port range interval code in the port_mapping isolator.
Date Tue, 22 Aug 2017 20:07:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61538/#review183511
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Line 2494 (original), 2503 (patched)
<https://reviews.apache.org/r/61538/#comment259520>

    Like you did above, return a Failure if this go out of uint16 bound?



src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Line 2979 (original), 2989 (patched)
<https://reviews.apache.org/r/61538/#comment259521>

    Ditto on returnning Failure here?


- Jie Yu


On Aug. 22, 2017, 6:56 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61538/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switched the port_mapping isolator over to start using the
> common values code to parse port ranges into an IntervalSet.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 57d4ccd515b538eece94a228916ec764c83473be

> 
> 
> Diff: https://reviews.apache.org/r/61538/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message