-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61697/#review183331
-----------------------------------------------------------
src/checks/checker_process.cpp
Lines 644-650 (patched)
<https://reviews.apache.org/r/61697/#comment259368>
I'd rather `VLOG(1)` here. It seems we do `LOG(INFO)` for important messages in this file
(3 occurences). It is also consistent with other checks.
- Alexander Rukletsov
On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61697/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 11:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7861
> https://issues.apache.org/jira/browse/MESOS-7861
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the default executor include the output of the COMMAND
> (health) checks in its logs.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
>
>
> Diff: https://reviews.apache.org/r/61697/diff/3/
>
>
> Testing
> -------
>
> Manual tests.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
|