mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 61666: Added a test to verify filtering of resource reservations on agent.
Date Mon, 21 Aug 2017 10:12:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61666/#review183321
-----------------------------------------------------------




src/tests/slave_authorization_tests.cpp
Lines 106 (patched)
<https://reviews.apache.org/r/61666/#comment259359>

    _Only one default user…_



src/tests/slave_authorization_tests.cpp
Lines 164 (patched)
<https://reviews.apache.org/r/61666/#comment259363>

    I would rather have `acl->mutable_roles()->add_value(role_name)`



src/tests/slave_authorization_tests.cpp
Lines 195 (patched)
<https://reviews.apache.org/r/61666/#comment259362>

    can you give it a better name to this role, even _test-role_ would do, but if you look
at api tests we use other things like _superhero_ or _muggle_.


- Alexander Rojas


On Aug. 15, 2017, 7:59 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61666/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7892
>     https://issues.apache.org/jira/browse/MESOS-7892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extends `SlaveAuthorizerTest.FilterStateEndpoint` test to
> check that `/state` endpoint shows resource reservations only for
> allowed principal.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp 536a8efda0cc1ba08285c379b01af6ec64a82117 
> 
> 
> Diff: https://reviews.apache.org/r/61666/diff/1/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message