mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61763: Added heartbeat interval for V1 Operator API.
Date Fri, 18 Aug 2017 23:34:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61763/#review183280
-----------------------------------------------------------




src/tests/api_tests.cpp
Line 2440 (original), 2447 (patched)
<https://reviews.apache.org/r/61763/#comment259297>

    You can move this statement before the `for` loop (i.e. we only need to call it once).



src/tests/api_tests.cpp
Line 2448 (original), 2455 (patched)
<https://reviews.apache.org/r/61763/#comment259298>

    Since you paused the clock above, resume the clock right before the end of the test:
    
    ```
    Clock::resume();
    ```


- Greg Mann


On Aug. 18, 2017, 11:11 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61763/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 11:11 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-7695
>     https://issues.apache.org/jira/browse/MESOS-7695
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the heartbeat interval parameter to the SUBSCRIBED event for
> V1 operator API. Updated the heartbeat test case to check the
> heartbeat interval.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 7dc5881b843addc2ec59fadb45f31049c7e5a588 
>   include/mesos/v1/master/master.proto db19c5ccc8aca78f901e72f3caf6d46761270bdd 
>   src/master/http.cpp b09a9d0ab5fab179d0e400932dce7d3ca958d7a8 
>   src/tests/api_tests.cpp 34480ea6818c904c64cb678562866f0b43dae0d6 
> 
> 
> Diff: https://reviews.apache.org/r/61763/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message