mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 61668: Added support for kill policies to the default executor.
Date Tue, 15 Aug 2017 18:59:12 GMT


> On Aug. 15, 2017, 6:09 p.m., Gastón Kleiman wrote:
> > src/launcher/default_executor.cpp
> > Line 995 (original), 1001 (patched)
> > <https://reviews.apache.org/r/61668/diff/1/?file=1798016#file1798016line1001>
> >
> >     We should send a TASK_KILLING update here, and address the TODOs added by AlexR.

Good catch! I had missed that since I sent out this patch before updating the tests.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182974
-----------------------------------------------------------


On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 5:40 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6535
>     https://issues.apache.org/jira/browse/MESOS-6535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92 
> 
> 
> Diff: https://reviews.apache.org/r/61668/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message