mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 60721: Stout: Made `Duration::parse()` handle durations out of range.
Date Sat, 12 Aug 2017 01:02:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60721/
-----------------------------------------------------------

(Updated Aug. 12, 2017, 1:02 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

Fixed whitespace.


Bugs: MESOS-7661
    https://issues.apache.org/jira/browse/MESOS-7661


Repository: mesos


Description
-------

Made `Duration:parse()` return an error if the argument is out of the
range that a `Duration` can represent.


Diffs (updated)
-----

  3rdparty/stout/include/stout/duration.hpp b0cd77b833f6fbf752b4db820fd43b87e1d1e476 
  3rdparty/stout/tests/duration_tests.cpp 59b08f14849a8db31f11fbd0b2e1248c99afd9dd 


Diff: https://reviews.apache.org/r/60721/diff/5/

Changes: https://reviews.apache.org/r/60721/diff/4-5/


Testing
-------

Added a new expectation to an existing test and confirmed that tests still pass.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message