mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61288: Linked `libprocess` to `stout` interface library.
Date Tue, 08 Aug 2017 01:22:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61288/#review182352
-----------------------------------------------------------


Ship it!




[Tentative "Ship It!" as I review this entire chain.]

I'm going to mention https://reviews.apache.org/r/61286/ in the commit description.  (And
I might tweak your chain's dependencies a little later, so that they are logically grouped.)

- Joseph Wu


On Aug. 1, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61288/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 5:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Linked `libprocess` to `stout` interface library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 75af774e1460319cef1efdf801eb97f34eada0e7

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 5a23990825de04f27bd5f74c82e10b702974f875

>   3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d 
> 
> 
> Diff: https://reviews.apache.org/r/61288/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message