mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Review Request 61438: Improved `NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess`.
Date Sat, 05 Aug 2017 00:06:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61438/
-----------------------------------------------------------

Review request for mesos, Kevin Klues and Vinod Kone.


Repository: mesos


Description
-------

Change the test so that the agent offesr as many GPUs as available on
the box instead of restricting it to 1. This way the test will fail if
there's a bug that makes the isolator give a task access to more GPUs
than what it was allocated.


Diffs
-----

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 9a78ae65c1cd414b5093b54ff51724e31e31c9d3



Diff: https://reviews.apache.org/r/61438/diff/1/


Testing
-------

`GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter="*NvidiaGpuTest.*Verify*" --verbose` passed
on a machine with 4 Nvidia GPUs.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message