mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.
Date Thu, 03 Aug 2017 21:40:48 GMT


> On July 29, 2017, 3:12 p.m., Armand Grillet wrote:
> > src/python/lib/mesos/http.py
> > Lines 119 (patched)
> > <https://reviews.apache.org/r/61172/diff/1/?file=1784420#file1784420line119>
> >
> >     Missing period, s/`verb`/`token` according to https://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html.

changed to "...with given method..."


> On July 29, 2017, 3:12 p.m., Armand Grillet wrote:
> > src/python/lib/mesos/http.py
> > Lines 162 (patched)
> > <https://reviews.apache.org/r/61172/diff/1/?file=1784420#file1784420line162>
> >
> >     Missing period.

dropped the JSONResource class as it is actually a bad design. Moved all json methods to the
Resource class.


> On July 29, 2017, 3:12 p.m., Armand Grillet wrote:
> > src/python/lib/requirements.in
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/61172/diff/1/?file=1784421#file1784421line1>
> >
> >     Not sure about using `<=` here and in the lines below, would use `<` so
that we keep the same main dependency versions.

good catch. not sure why i added = (facepalm)


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review181756
-----------------------------------------------------------


On Aug. 3, 2017, 9:15 p.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61172/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 9:15 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mesos.http and mesos.exceptions for CLI.
> 
> Part of MESOS-7310, this patch adds the mesos.http and mesos.exceptions modules, which
provides a Resource class and its descendants for abstracting away common operations over
http connectioins with JSON serialization.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442 
>   src/python/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818 
>   src/python/lib/mesos/exceptions.py PRE-CREATION 
>   src/python/lib/mesos/http.py PRE-CREATION 
>   src/python/lib/requirements.in e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/tests/conftest.py PRE-CREATION 
>   src/python/lib/tests/test_exceptions.py PRE-CREATION 
>   src/python/lib/tests/test_http.py PRE-CREATION 
>   src/python/lib/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054 
> 
> 
> Diff: https://reviews.apache.org/r/61172/diff/2/
> 
> 
> Testing
> -------
> 
> under src/python/lib, call `tox` for running unit tests. The test should pass and test
coverage should be at 100%.
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message