mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 61365: Added `get_byproducts()` function to fix Ninja generator.
Date Wed, 02 Aug 2017 00:59:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61365/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

CMake also supports Ninja as a generator, but Ninja requires that each
use of `ExternalProject_Add` specifies its `BUILD_BYPRODUCTS`.
Interestingly, it doesn't care about interface libraries, and
furthermore, it can't derive the dependency from other
information (despite it being available).


Diffs
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61365/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message