mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 61219: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNSWildcardMatch`.
Date Tue, 01 Aug 2017 06:44:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61219/#review181879
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/tests/containerizer/cni_isolator_tests.cpp
Lines 1383-1385 (patched)
<https://reviews.apache.org/r/61219/#comment257670>

    Can we change this to:
    A DNS information with `network_mode = CNI`, but without a network name, acts as a wild
card match making it the default DNS for any CNI network not specified in the `--default_container_dns`
flag.


- Avinash sridharan


On July 28, 2017, 2:35 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61219/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 2:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNSWildcardMatch`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp ae0980bd671849fcd3e19941b33c7d3b09fdae7c

> 
> 
> Diff: https://reviews.apache.org/r/61219/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message