Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0203D200CE3 for ; Sun, 30 Jul 2017 02:35:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF273164AB9; Sun, 30 Jul 2017 00:35:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 40AE0164AAD for ; Sun, 30 Jul 2017 02:35:12 +0200 (CEST) Received: (qmail 23292 invoked by uid 500); 30 Jul 2017 00:35:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23280 invoked by uid 99); 30 Jul 2017 00:35:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Jul 2017 00:35:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AED7B1A066F; Sun, 30 Jul 2017 00:35:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id sB8thXKaaMSO; Sun, 30 Jul 2017 00:35:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C14425F665; Sun, 30 Jul 2017 00:35:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2A8C7E0059; Sun, 30 Jul 2017 00:35:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0DB6CC401D3; Sun, 30 Jul 2017 00:35:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1076782652343267992==" MIME-Version: 1.0 Subject: Re: Review Request 61060: Cached a reference to a ProcessBase in every UPID. From: Benjamin Mahler To: Benjamin Mahler Cc: Benjamin Hindman , mesos Date: Sun, 30 Jul 2017 00:35:05 -0000 Message-ID: <20170730003505.63649.74896@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61060/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20170722011835.6572.2256@reviews-vm2.apache.org> In-Reply-To: <20170722011835.6572.2256@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos archived-at: Sun, 30 Jul 2017 00:35:13 -0000 --===============1076782652343267992== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61060/#review181761 ----------------------------------------------------------- Ship it! Some TODOs with thoughts on the longer term plan here that we discussed would be great! (i.e. don't let users mutate the fields, hide resolve(), etc) - Benjamin Mahler On July 22, 2017, 1:18 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61060/ > ----------------------------------------------------------- > > (Updated July 22, 2017, 1:18 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7798 > https://issues.apache.org/jira/browse/MESOS-7798 > > > Repository: mesos > > > Description > ------- > > Cached a reference to a ProcessBase in every UPID. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/pid.hpp 6ed936db2e45f3aab2c3765d57772844e702f914 > 3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c > 3rdparty/libprocess/src/pid.cpp 634ac44337980fec03ceadaa81a7557d6a714af8 > 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c > 3rdparty/libprocess/src/process_reference.hpp a6d6d20e3f40634c5e16fd193443e5f1e02faff5 > > > Diff: https://reviews.apache.org/r/61060/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > > --===============1076782652343267992==--