Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F0A2200CD3 for ; Fri, 28 Jul 2017 23:36:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8D8AE16D909; Fri, 28 Jul 2017 21:36:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D27E116D907 for ; Fri, 28 Jul 2017 23:36:12 +0200 (CEST) Received: (qmail 25087 invoked by uid 500); 28 Jul 2017 21:36:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 25069 invoked by uid 99); 28 Jul 2017 21:36:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 21:36:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5D750C3643; Fri, 28 Jul 2017 21:36:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id wzXS4FcMomEf; Fri, 28 Jul 2017 21:36:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AC6C95FC12; Fri, 28 Jul 2017 21:36:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 164B1E00A3; Fri, 28 Jul 2017 21:36:09 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 9B56AC40110; Fri, 28 Jul 2017 21:36:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4860312162599978360==" MIME-Version: 1.0 Subject: Re: Review Request 61180: Added a resource providers total resources to the subscribe call. From: Jie Yu To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , mesos Date: Fri, 28 Jul 2017 21:36:07 -0000 Message-ID: <20170728213607.64276.41572@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61180/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20170727144946.56759.12613@reviews-vm2.apache.org> In-Reply-To: <20170727144946.56759.12613@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jie Yu X-ReviewRequest-Repository: mesos archived-at: Fri, 28 Jul 2017 21:36:13 -0000 --===============4860312162599978360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61180/#review181732 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On July 27, 2017, 2:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61180/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 2:49 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7837 > https://issues.apache.org/jira/browse/MESOS-7837 > > > Repository: mesos > > > Description > ------- > > Since resource provider resources are dynamic (as opposed to how e.g., > agent total resources are implemented), they are not part of the > 'ResourceProviderInfo'. Instead they are communicated explicitly. > > This commit adds total resources the resource provider 'SUBSCRIBE' > call which can be used to communicate the total capacity in both > subscription and resubscription scenarios. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed > include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2 > > > Diff: https://reviews.apache.org/r/61180/diff/1/ > > > Testing > ------- > > Tested as part of https://reviews.apache.org/r/61182/. > > > Thanks, > > Benjamin Bannier > > --===============4860312162599978360==--