Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1175277763363372837=="
MIME-Version: 1.0
Subject: Re: Review Request 61157: Refactored ProcessManager::handle for
 future use with http::Server.
From: Mesos Reviewbot Windows <reviews@mesos.apache.org>
To: Benjamin Mahler <bmahler@apache.org>
Cc: Mesos Reviewbot Windows <reviews@mesos.apache.org>,
 Benjamin Hindman <benh@berkeley.edu>, mesos <reviews@mesos.apache.org>
Date: Thu, 27 Jul 2017 02:00:36 -0000
Message-ID: <20170727020036.51161.44192@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Mesos Reviewbot Windows <noreply@reviews.apache.org>
References: <20170727015546.51162.82434@reviews-vm2.apache.org>
In-Reply-To: <20170727015546.51162.82434@reviews-vm2.apache.org>
Reply-To: Mesos Reviewbot Windows <reviews@mesos.apache.org>
archived-at: Thu, 27 Jul 2017 02:00:45 -0000

--===============1175277763363372837==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61157/#review181523
-----------------------------------------------------------


Bad patch!

Reviews applied: [61157, 61156, 61155, 61154, 61153, 61152, 61151, 61150, 61149, 61148, 61147, 55324, 55323, 55322, 55321, 55320]

Failed command: python support/apply-reviews.py -n -r 55320

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 191, in fetch_patch
    context=ssl_create_default_context())
  File "C:\Python27\lib\urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "C:\Python27\lib\urllib2.py", line 435, in open
    response = meth(req, response)
  File "C:\Python27\lib\urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Python27\lib\urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "C:\Python27\lib\urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "C:\Python27\lib\urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: NOT FOUND

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/204/console

- Mesos Reviewbot Windows


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61157/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored ProcessManager::handle for future use with http::Server.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 
>   3rdparty/libprocess/src/tests/process_tests.cpp ed11909a2a5e3214fa974bdea098f4057cea9666 
> 
> 
> Diff: https://reviews.apache.org/r/61157/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


--===============1175277763363372837==--