Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============4504825818792871571=="
MIME-Version: 1.0
Subject: Re: Review Request 61122: Fixed the host volume relative host path
 ownership.
From: James Peach <jpeach@apache.org>
To: Jiang Yan Xu <yan@jxu.me>, Jie Yu <yujie.jay@gmail.com>,
 Stephan Erb <serb@apache.org>, Vinod Kone <vinodkone@gmail.com>,
 Ilya Pronin <ipronin@twopensource.com>, James Peach <jpeach@apache.org>
Cc: Gilbert Song <songzihao1990@gmail.com>, mesos <reviews@mesos.apache.org>
Date: Wed, 26 Jul 2017 17:04:02 -0000
Message-ID: <20170726170402.50051.45868@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: James Peach <noreply@reviews.apache.org>
References: <20170726064152.51161.5388@reviews-vm2.apache.org>
In-Reply-To: <20170726064152.51161.5388@reviews-vm2.apache.org>
Reply-To: James Peach <jpeach@apache.org>
archived-at: Wed, 26 Jul 2017 17:04:08 -0000

--===============4504825818792871571==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61122/#review181468
-----------------------------------------------------------


Fix it, then Ship it!


src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 440 (patched)
<https://reviews.apache.org/r/61122/#comment257076>

    We probably should expose a `os::stat::stat()`, but this should be:
    ```
    return ErrnoError("Failed to stat ...");
    ```


src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 509 (patched)
<https://reviews.apache.org/r/61122/#comment257077>

    Should this be `UID` and `GID`?


- James Peach


On July 26, 2017, 6:41 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61122/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 6:41 a.m.)
> 
> 
> Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5187
>     https://issues.apache.org/jira/browse/MESOS-5187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This bugfix addresses the issue from MESOS-5178. Basically, the
> host volume ownership was not set correctly. This issue can be
> exposed if a framework user is non-root while the agent
> process runs as root. Then, the non-root user does not have
> permissions to write to this volume.
> 
> The correct solution should be giving permissions to corresponding
> users by leveraging supplementary groups. But we can still
> introduce a workaround in this patch by changing the ownership
> of this host volume to its sandbox's ownership.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp bf35b7f00d6e80672ffc27cfc3f3a2fd8de69a99 
> 
> 
> Diff: https://reviews.apache.org/r/61122/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


--===============4504825818792871571==--