Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 311F9200CDF for ; Wed, 26 Jul 2017 02:04:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2F8AC167CE7; Wed, 26 Jul 2017 00:04:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7A44E167CE5 for ; Wed, 26 Jul 2017 02:04:00 +0200 (CEST) Received: (qmail 9678 invoked by uid 500); 26 Jul 2017 00:03:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9667 invoked by uid 99); 26 Jul 2017 00:03:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 00:03:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0664C1A089F; Wed, 26 Jul 2017 00:03:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id L3W0JIIRfFjW; Wed, 26 Jul 2017 00:03:58 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CF7535F340; Wed, 26 Jul 2017 00:03:57 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7482CE00A3; Wed, 26 Jul 2017 00:03:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0A989C40495; Wed, 26 Jul 2017 00:03:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2816505661539011131==" MIME-Version: 1.0 Subject: Review Request 61126: Converted Timer value to counting semantics. From: James Peach To: Kevin Klues , Benjamin Mahler , Jiang Yan Xu Cc: James Peach , mesos Date: Wed, 26 Jul 2017 00:03:56 -0000 Message-ID: <20170726000356.9520.84085@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61126/ X-Sender: James Peach Reply-To: James Peach X-ReviewRequest-Repository: mesos archived-at: Wed, 26 Jul 2017 00:04:01 -0000 --===============2816505661539011131== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61126/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu. Bugs: MESOS-6918 https://issues.apache.org/jira/browse/MESOS-6918 Repository: mesos Description ------- The value of a Timer was the elapsed time fo the last timed interval which is not a valua that can be easily graphed or interpreted. Replaced this with a counter which tracks the cumulative elapsed time of all the measurements on this Timer. This allows a monitoring application to plot the elapsed time as a rate. Diffs ----- 3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d 3rdparty/libprocess/src/tests/metrics_tests.cpp 161ca0dc7aea526d450d71a80839d8cc075aaa31 Diff: https://reviews.apache.org/r/61126/diff/1/ Testing ------- make check (Fedora 26). Note that this requires Mesos test changes in r/61127. Thanks, James Peach --===============2816505661539011131==--