Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 46383200CCB for ; Thu, 6 Jul 2017 07:03:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 447DE165580; Thu, 6 Jul 2017 05:03:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9194C16557F for ; Thu, 6 Jul 2017 07:03:08 +0200 (CEST) Received: (qmail 8725 invoked by uid 500); 6 Jul 2017 05:03:07 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8652 invoked by uid 99); 6 Jul 2017 05:03:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 05:03:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B0D961AA94C; Thu, 6 Jul 2017 05:03:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 1OlbzV1yCv7C; Thu, 6 Jul 2017 05:03:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C0A7561067; Thu, 6 Jul 2017 05:03:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9F31E0012; Thu, 6 Jul 2017 05:03:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6E878C40063; Thu, 6 Jul 2017 05:03:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6344137518833227719==" MIME-Version: 1.0 Subject: Re: Review Request 60675: Fixed compilation failure in port-mapping network isolator. From: Avinash sridharan To: Joseph Wu Cc: Mesos Reviewbot Windows , Avinash sridharan , mesos Date: Thu, 06 Jul 2017 05:03:02 -0000 Message-ID: <20170706050302.62134.80747@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60675/ X-Sender: Avinash sridharan References: <20170706041152.36468.61126@reviews-vm2.apache.org> In-Reply-To: <20170706041152.36468.61126@reviews-vm2.apache.org> Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos archived-at: Thu, 06 Jul 2017 05:03:09 -0000 --===============6344137518833227719== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60675/ ----------------------------------------------------------- (Updated July 6, 2017, 5:03 a.m.) Review request for mesos and Joseph Wu. Changes ------- Fixed another missing `IPNetwork` instance. Bugs: MESOS-7762 https://issues.apache.org/jira/browse/MESOS-7762 Repository: mesos Description ------- Fixed compilation failure in port-mapping network isolator. Diffs (updated) ----- src/linux/routing/filter/icmp.hpp bc0aed0f4fc7c48f06cece14aa9ec43d7fa36bc4 src/linux/routing/route.hpp 01d4e7582b19a38bc39f8c394121fe0bed2c0d87 src/linux/routing/route.cpp ceeaf8e557a88569e1f15b3ffc5f0746b66ea638 src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94 src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966 src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a Diff: https://reviews.apache.org/r/60675/diff/2/ Changes: https://reviews.apache.org/r/60675/diff/1-2/ Testing ------- make check Thanks, Avinash sridharan --===============6344137518833227719==--