Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8840857897829008695=="
MIME-Version: 1.0
Subject: Re: Review Request 60638: Adjusted allocator interfaces to allow
 passing new agent total.
From: Jie Yu <yujie.jay@gmail.com>
To: Jie Yu <yujie.jay@gmail.com>, Benjamin Mahler <bmahler@apache.org>,
 Jan Schlicht <jan@mesosphere.io>
Cc: Benjamin Bannier <benjamin.bannier@mesosphere.io>,
 mesos <reviews@mesos.apache.org>
Date: Wed, 05 Jul 2017 17:34:13 -0000
Message-ID: <20170705173413.62134.32862@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Jie Yu <noreply@reviews.apache.org>
References: <20170704144026.53935.5441@reviews-vm2.apache.org>
In-Reply-To: <20170704144026.53935.5441@reviews-vm2.apache.org>
Reply-To: Jie Yu <yujie.jay@gmail.com>
archived-at: Wed, 05 Jul 2017 17:34:19 -0000

--===============8840857897829008695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60638/#review179659
-----------------------------------------------------------


include/mesos/allocator/allocator.hpp
Line 219 (original), 220-221 (patched)
<https://reviews.apache.org/r/60638/#comment254468>

    It's quite confusing to the readers when there are two fields there. Does 'total' include 'oversubscribed' resources?
    
    I am wondering if we can combine these two fields in the allocator. Updating 'oversubscribed' is a special case of updating 'total'?


- Jie Yu


On July 4, 2017, 2:40 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60638/
> -----------------------------------------------------------
> 
> (Updated July 4, 2017, 2:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7755
>     https://issues.apache.org/jira/browse/MESOS-7755
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adjust interfaces, implementations and users of the
> 'updateSlave' method. This allows to pass an additional argument
> denoting an updated 'total' amount of resource on the agents.
> 
> In a subsequent commit we will update the 'HierarchicalAllocator' to
> interpret this value.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
>   src/master/allocator/mesos/allocator.hpp 2e780c92d5c5132abff32f1ce051c3bab2947f37 
>   src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
>   src/master/allocator/mesos/hierarchical.cpp eb01d8e6b1108866ebc049f9f4a46157823a3541 
>   src/master/master.cpp 95e9691b3e3ef101e3e7ddc7a498d5c5bf2276e3 
>   src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 
>   src/tests/hierarchical_allocator_tests.cpp 2a312a9af4bae679a0a4e7bf45a3c013513c5da2 
> 
> 
> Diff: https://reviews.apache.org/r/60638/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with https://reviews.apache.org/r/60639/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


--===============8840857897829008695==--