mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61182: Sent a resource provider message when providers subscribe.
Date Mon, 31 Jul 2017 21:53:27 GMT


> On July 28, 2017, 10:03 p.m., Jie Yu wrote:
> > src/resource_provider/message.hpp
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/61182/diff/1/?file=1784497#file1784497line29>
> >
> >     With ERP in mind, maybe it's more approapriate to make this message for a single
resource provider? For instance:
> >     
> >     ```
> >     struct ResourceProviderMessage
> >     {
> >       enum class Type
> >       {
> >         UPDATE_TOTAL_RESOURCES,
> >       };
> >       
> >       struct UpdateTotalResources
> >       {
> >         Option<ResourceProviderID> id;
> >         Resources total;
> >       };
> >     
> >       Type type;
> >       
> >       UpdateTotalResources updateTotalResources;
> >     };
> >     ```
> 
> Benjamin Bannier wrote:
>     I am not sure we need to do this right now. Independent of ERP/LRP, splitting this
up along RPs would somewhat help us to
>     
>     * keep the transfered `total` small, and
>     * make it easier to perform RP-specific actions when a RP changes (e.g., to implement
simple resource health actions).
>     
>     OTOH it should be possible to implement this without complicating the protocol.
>     
>     Could we punt on that one for now?
>     
>     * * *
>     
>     I took your suggestion and renamed `s/TOTAL/UPDATE_TOTAL_RESOURCES` in this patch.

The reason I was pushing for per provider update message is because the agent logic will be
different. If we agree that per provider update is the way to go in the future, we should
just do it right now so that we don't need to adjust the agent logic too much in the future.
what do you think?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/#review181734
-----------------------------------------------------------


On July 31, 2017, 3:08 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61182/
> -----------------------------------------------------------
> 
> (Updated July 31, 2017, 3:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7837
>     https://issues.apache.org/jira/browse/MESOS-7837
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to inform users of resource provider managers that the
> managed resources have changed, we add a new 'ResourceProviderMessage'
> type for communicating changes to the managed total resources.
> 
> We add code to trigger sending of that message when a resource
> provider subscribes with the manager.
> 
> In the future this message could also be used to communicate changes
> to an already subscribed resource provider's total resources.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5712bad2acc4cf0f8ec9b7febffcdb0fa77578c9 
>   src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462 
>   src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04 
>   src/tests/CMakeLists.txt 6dd2716de942adf6cefa5a464ef664f3c3ebb7a3 
>   src/tests/resource_provider_http_api_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5

>   src/tests/resource_provider_manager_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61182/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message