mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 61111: Extracted strings into constants in example frameworks.
Date Mon, 31 Jul 2017 21:22:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61111/
-----------------------------------------------------------

(Updated July 31, 2017, 9:22 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
-------

Included /r/61135 and /r/61136.


Summary (updated)
-----------------

Extracted strings into constants in example frameworks.


Bugs: MESOS-7814
    https://issues.apache.org/jira/browse/MESOS-7814


Repository: mesos


Description (updated)
-------

This impacts the balloon, disk full, and docker no executor frameworks.


Diffs (updated)
-----

  src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
  src/examples/disk_full_framework.cpp 215b6d29cf5f52973f2b211e9fc72ca6ec2afa7a 
  src/examples/docker_no_executor_framework.cpp 4a58f11fc8892f23ade1d8c872ab9b4fc580d478 


Diff: https://reviews.apache.org/r/61111/diff/3/

Changes: https://reviews.apache.org/r/61111/diff/2-3/


Testing
-------

$ make check


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message