mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61060: Cached a reference to a ProcessBase in every UPID.
Date Sun, 30 Jul 2017 00:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61060/#review181761
-----------------------------------------------------------


Ship it!




Some TODOs with thoughts on the longer term plan here that we discussed would be great! (i.e.
don't let users mutate the fields, hide resolve(), etc)

- Benjamin Mahler


On July 22, 2017, 1:18 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61060/
> -----------------------------------------------------------
> 
> (Updated July 22, 2017, 1:18 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
>     https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cached a reference to a ProcessBase in every UPID.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/pid.hpp 6ed936db2e45f3aab2c3765d57772844e702f914

>   3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c

>   3rdparty/libprocess/src/pid.cpp 634ac44337980fec03ceadaa81a7557d6a714af8 
>   3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 
>   3rdparty/libprocess/src/process_reference.hpp a6d6d20e3f40634c5e16fd193443e5f1e02faff5

> 
> 
> Diff: https://reviews.apache.org/r/61060/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message