mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61149: Added Future::condition.
Date Fri, 28 Jul 2017 02:17:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61149/#review181641
-----------------------------------------------------------




3rdparty/libprocess/include/process/future.hpp
Lines 155-156 (patched)
<https://reviews.apache.org/r/61149/#comment257268>

    I'm not sure callers will grasp this, to me this is stringification of the future, and
in the READY case it would print `'Ready with X'`. Is there a way to acheive this when T isn't
printable (e.g. `'Ready with <unprintable value>'`


- Benjamin Mahler


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61149/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Future::condition.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp cce950509f58022e79bb51a6e72ea1a005b9cb50

> 
> 
> Diff: https://reviews.apache.org/r/61149/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message