mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 61126: Converted Timer value to counting semantics.
Date Wed, 26 Jul 2017 00:03:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61126/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-6918
    https://issues.apache.org/jira/browse/MESOS-6918


Repository: mesos


Description
-------

The value of a Timer was the elapsed time fo the last timed
interval which is not a valua that can be easily graphed
or interpreted. Replaced this with a counter which tracks
the cumulative elapsed time of all the measurements on this
Timer. This allows a monitoring application to plot the elapsed
time as a rate.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d

  3rdparty/libprocess/src/tests/metrics_tests.cpp 161ca0dc7aea526d450d71a80839d8cc075aaa31



Diff: https://reviews.apache.org/r/61126/diff/1/


Testing
-------

make check (Fedora 26). Note that this requires Mesos test changes in r/61127.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message