mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61066: Added 'process::workers'.
Date Mon, 24 Jul 2017 23:59:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61066/#review181295
-----------------------------------------------------------


Fix it, then Ship it!




Have you considered having a test for this function?


3rdparty/libprocess/include/process/process.hpp
Line 545 (original), 545-548 (patched)
<https://reviews.apache.org/r/61066/#comment256821>

    Can you comment on the const-ness of this? Right now it's fixed, but we've explored the
idea of having it be dynamic, maybe explain that the current implementation uses a fixed size
worker pool?
    
    Might also be worth clarifying what a worker is? E.g. not the event loop thread.


- Benjamin Mahler


On July 24, 2017, 1:49 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61066/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 1:49 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'process::workers'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c

>   3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 694a842e8e18d82ac551749a71764825ba7cb3a9

> 
> 
> Diff: https://reviews.apache.org/r/61066/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message