mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61093: Windows: Disabled permissive building.
Date Mon, 24 Jul 2017 23:30:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61093/#review181289
-----------------------------------------------------------


Ship it!




The additional flag looks odd enough to warrant putting this blog post in a comment or commit
message somewhere:
https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/

- Joseph Wu


On July 24, 2017, 4:11 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61093/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 4:11 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag enables warnings for non standards conformant code.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 847ae1aeea61ce9082cbcea16138f447c9558243 
> 
> 
> Diff: https://reviews.apache.org/r/61093/diff/1/
> 
> 
> Testing
> -------
> 
> Warning: this requires Visual Studio 2017.
> 
> Built all test targets on Windows.
> 
> Observed: `... /errorReport:queue   /bigobj /vd2 /permissive-  /Zm170 "C:\Users\andschwa\src\mesos-bugfix\src\slave\constants.cpp`
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message