mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60500: Introduced `--default_container_dns` agent flag.
Date Sun, 23 Jul 2017 09:29:30 GMT


> On July 22, 2017, 12:34 a.m., Avinash sridharan wrote:
> > src/messages/flags.proto
> > Lines 44 (patched)
> > <https://reviews.apache.org/r/60500/diff/3/?file=1780268#file1780268line44>
> >
> >     I know we are using this `USER` mode from the docker terminology, but I would
really like to move away from that terminology if possible and be explicit here that this
is a CNI network? Instead of calling this mode `USER` can we just call it `CNI?

Good point!


> On July 22, 2017, 12:34 a.m., Avinash sridharan wrote:
> > src/messages/flags.proto
> > Lines 49-54 (patched)
> > <https://reviews.apache.org/r/60500/diff/3/?file=1780268#file1780268line49>
> >
> >     Can we change this to:
> >     
> >     This field is valid only when the `network_mode` is set to `CNI`. It is invalid
when the `network_mode` is `HOST`. When the mode is `CNI` this field informs the `network/cni`
isolator about the `CNI` network to which the DNS configuration applies. Also, if the mode
is `CNI` and this field is not set it implies wild card semantics for the CNI network name,
informing the `network/cni` isolator that the DNS configuration applies to "all" CNI networks.

> >     
> >     NOTE: If there are multiple `MesosDNS` configuration specified, when applyig
a DNS configuration to a CNI network the container will always choose the most specific match
based on the CNI network name.

Agree!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60500/#review181121
-----------------------------------------------------------


On July 23, 2017, 5:29 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60500/
> -----------------------------------------------------------
> 
> (Updated July 23, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--default_container_dns` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d 
>   src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 
>   src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 
>   src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3 
>   src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7 
>   src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 
> 
> 
> Diff: https://reviews.apache.org/r/60500/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message