mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60957: Added a time window for Timer metrics.
Date Wed, 19 Jul 2017 20:30:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60957/#review180973
-----------------------------------------------------------




src/master/registrar.cpp
Line 156 (original), 156 (patched)
<https://reviews.apache.org/r/60957/#comment256355>

    There is only a single fetch, so this intentionally omits the time window since getting
a distribution for a single data point isn't useful.


- Benjamin Mahler


On July 19, 2017, 9:04 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60957/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 9:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6918
>     https://issues.apache.org/jira/browse/MESOS-6918
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a time window argument for the Timer metrics that were missing it.
> 
> 
> Diffs
> -----
> 
>   src/master/registrar.cpp 242cd0a4f1fad327dcc1a59260f46987cfeba59c 
>   src/state/log.cpp b71383906cf28fe0769cbb620387a0e0134f01f9 
> 
> 
> Diff: https://reviews.apache.org/r/60957/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message