mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 60917: Used a real UPID to send `LearnedMessage`.
Date Tue, 18 Jul 2017 16:01:35 GMT


> On July 17, 2017, 5:37 p.m., Joseph Wu wrote:
> > src/log/network.hpp
> > Line 247 (original), 248-250 (patched)
> > <https://reviews.apache.org/r/60917/diff/1/?file=1777905#file1777905line248>
> >
> >     I'd prefer this comment to be a `NOTE: ...`
> >     
> >     :)

Sure :)


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60917/#review180773
-----------------------------------------------------------


On July 17, 2017, noon, Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60917/
> -----------------------------------------------------------
> 
> (Updated July 17, 2017, noon)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7753
>     https://issues.apache.org/jira/browse/MESOS-7753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously an empty UPID `@0.0.0.0:0` was used which could result in
> the message being dropped due to certain security check (MESOS-7401).
> 
> 
> Diffs
> -----
> 
>   src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b 
> 
> 
> Diff: https://reviews.apache.org/r/60917/diff/1/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message