mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Chung <cinchu...@gmail.com>
Subject Re: Review Request 60899: Moved new Mesos CLI to src/python/.
Date Mon, 17 Jul 2017 22:02:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60899/#review180746
-----------------------------------------------------------


Ship it!




otherwise lgtm, ship it!

- Eric Chung


On July 16, 2017, 7:33 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60899/
> -----------------------------------------------------------
> 
> (Updated July 16, 2017, 7:33 p.m.)
> 
> 
> Review request for mesos, Eric Chung and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change allows to have all the Python files under
> only two directories : src/python/ and support/. This
> will improve the structure of our Python code in the future
> by sharing configuration files and virtual environments.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/.gitignore 3ce5f74748dae6ac60170a1f0c73191fc26177d9 
>   src/cli_new/README.md  
>   src/cli_new/activate  
>   src/cli_new/bin/main.py  
>   src/cli_new/bin/mesos  
>   src/cli_new/bin/mesos-cli-tests  
>   src/cli_new/bin/settings.py  
>   src/cli_new/bootstrap 4193d3f38961747a6f5e60a8cd1715eff76d660e 
>   src/cli_new/deactivate  
>   src/cli_new/lib/cli/__init__.py  
>   src/cli_new/lib/cli/config.py  
>   src/cli_new/lib/cli/docopt.py  
>   src/cli_new/lib/cli/exceptions.py  
>   src/cli_new/lib/cli/http.py  
>   src/cli_new/lib/cli/plugins/__init__.py  
>   src/cli_new/lib/cli/plugins/base.py  
>   src/cli_new/lib/cli/plugins/config/__init__.py  
>   src/cli_new/lib/cli/plugins/config/main.py  
>   src/cli_new/lib/cli/tests/__init__.py  
>   src/cli_new/lib/cli/tests/base.py 62a4ee8ac2d39c8ecd400560aa51485cab0410f2 
>   src/cli_new/lib/cli/tests/constants.py  
>   src/cli_new/lib/cli/tests/tests.py  
>   src/cli_new/lib/cli/util.py  
>   src/cli_new/mesos.bash_completion  
>   src/cli_new/pip-requirements.txt  
>   src/cli_new/pylint.config  
>   src/cli_new/tests/main.py  
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60899/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
> I also checked that the Python linter was still working.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message