mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60847: Added test cases for /slaves, /containers, /frameworks endpoints.
Date Fri, 14 Jul 2017 00:17:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60847/#review180498
-----------------------------------------------------------




src/tests/slave_tests.cpp
Lines 2393-2397 (original), 2401-2420 (patched)
<https://reviews.apache.org/r/60847/#comment255707>

    Let's namespace this to help readability:
    
    ```
    // Launch two tasks, each under a different executor.
    vector<TaskInfo> tasks;
    
    {
    
      TaskInfo task;
      task.set_name("");
      task.mutable_task_id()->set_value("1");
      task.mutable_slave_id()->MergeFrom(offers->front().slave_id());
      task.mutable_resources()->MergeFrom(
          Resources::parse("cpus:1;mem:512").get());
      task.mutable_executor()->MergeFrom(executor1);
      
      tasks.push_back(task);
    }
    
    {
      TaskInfo task;
      task.set_name("");
      task.mutable_task_id()->set_value("2");
      task.mutable_slave_id()->MergeFrom(offers->front().slave_id());
      task.mutable_resources()->MergeFrom(
          Resources::parse("cpus:1;mem:512").get());
      task.mutable_executor()->MergeFrom(executor2);
    
      tasks.push_back(task);
    }
    ```


- Greg Mann


On July 13, 2017, 9:11 p.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60847/
> -----------------------------------------------------------
> 
> (Updated July 13, 2017, 9:11 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added query parameter test cases for '/slaves' and '/frameworks' on
> the master, and '/containers' endpoint on the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 6e6461c2e13c3eb055aa3c2d8ad8e3ac54a1d197 
>   src/tests/slave_tests.cpp 035db18db3a64a9e358c1c54cc18a4bdeb85d8bf 
> 
> 
> Diff: https://reviews.apache.org/r/60847/diff/1/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework"
--gtest_repeat=1000 --gtest_break_on_failure'
> Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave"
--gtest_repeat=1000 --gtest_break_on_failure'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message