mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60342: Windows: Made version info use Unicode.
Date Tue, 11 Jul 2017 00:18:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60342/#review180131
-----------------------------------------------------------


Ship it!




- Joseph Wu


On June 21, 2017, 3:17 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60342/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 3:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu,
Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817
>     https://issues.apache.org/jira/browse/MESOS-6817
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `GetVersionEx` family of functions have been marked deprecated; not
> just the non-Unicode version as the previous comment implied. Thus we do
> not hide the valid deprecation warning, and should replace the use of
> this API.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae

> 
> 
> Diff: https://reviews.apache.org/r/60342/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message