Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EB975200CC3 for ; Sat, 1 Jul 2017 01:46:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EA9A1160BF6; Fri, 30 Jun 2017 23:46:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3C73C160BEB for ; Sat, 1 Jul 2017 01:46:52 +0200 (CEST) Received: (qmail 99420 invoked by uid 500); 30 Jun 2017 23:46:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99404 invoked by uid 99); 30 Jun 2017 23:46:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2017 23:46:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B8C9B1AFADC; Fri, 30 Jun 2017 23:46:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.701 X-Spam-Level: **** X-Spam-Status: No, score=4.701 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id SSsRezOpxdpK; Fri, 30 Jun 2017 23:46:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EB7115F30B; Fri, 30 Jun 2017 23:46:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4FA09E06C4; Fri, 30 Jun 2017 23:46:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B9E5EC40044; Fri, 30 Jun 2017 23:46:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6931974697798141468==" MIME-Version: 1.0 Subject: Re: Review Request 60107: Added filtering to the '/tasks' endpoint. From: Quinn Leng To: Anand Mazumdar , Greg Mann , Vinod Kone , Alexander Rojas Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Quinn Leng , mesos Date: Fri, 30 Jun 2017 23:46:46 -0000 Message-ID: <20170630234646.20233.27495@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Quinn Leng X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60107/ X-Sender: Quinn Leng References: <20170630233737.20232.93748@reviews-vm2.apache.org> In-Reply-To: <20170630233737.20232.93748@reviews-vm2.apache.org> Reply-To: Quinn Leng X-ReviewRequest-Repository: mesos archived-at: Fri, 30 Jun 2017 23:46:53 -0000 --===============6931974697798141468== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ ----------------------------------------------------------- (Updated June 30, 2017, 11:46 p.m.) Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone. Bugs: MESOS-7630 https://issues.apache.org/jira/browse/MESOS-7630 Repository: mesos Description ------- Added filtering to the '/tasks' endpoint. Diffs (updated) ----- src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea Diff: https://reviews.apache.org/r/60107/diff/14/ Changes: https://reviews.apache.org/r/60107/diff/13-14/ Testing ------- Passed "make check" Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48" Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 --gtest_break_on_failure" Thanks, Quinn Leng --===============6931974697798141468==--