Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1872574851681222290=="
MIME-Version: 1.0
Subject: Re: Review Request 60369: Exposed allocated resources per each role in
 /state endpoint on agent.
From: haosdent huang <haosdent@apache.org>
To: haosdent huang <haosdent@apache.org>, Benjamin Mahler <bmahler@apache.org>
Cc: Andrei Budnik <abudnik@mesosphere.com>, mesos <reviews@mesos.apache.org>
Date: Tue, 27 Jun 2017 17:58:28 -0000
Message-ID: <20170627175828.20029.76050@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: haosdent huang <noreply@reviews.apache.org>
References: <20170627171005.20028.64417@reviews-vm2.apache.org>
In-Reply-To: <20170627171005.20028.64417@reviews-vm2.apache.org>
Reply-To: haosdent huang <haosdent@apache.org>
archived-at: Tue, 27 Jun 2017 17:58:34 -0000

--===============1872574851681222290==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
-----------------------------------------------------------


src/slave/http.cpp
Lines 1334-1344 (patched)
<https://reviews.apache.org/r/60369/#comment253387>

    Should we follow this pattern?
    
    ```
            writer->field(
                "reserved_resources_full",
                [&totalResources](JSON::ObjectWriter* writer) {
                  foreachpair (const string& role,
                               const Resources& resources,
                               totalResources.reservations()) {
    
    ```


src/slave/http.cpp
Lines 1344 (patched)
<https://reviews.apache.org/r/60369/#comment253381>

    Nit: Add one blank line below.


src/tests/reservation_endpoints_tests.cpp
Line 1739 (original), 1739 (patched)
<https://reviews.apache.org/r/60369/#comment253382>

    Nit: Add one blank line below.


- haosdent huang


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


--===============1872574851681222290==--