Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6FE3200CC5 for ; Tue, 27 Jun 2017 03:42:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B5C26160BDE; Tue, 27 Jun 2017 01:42:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 04892160BDA for ; Tue, 27 Jun 2017 03:42:23 +0200 (CEST) Received: (qmail 7043 invoked by uid 500); 27 Jun 2017 01:42:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 7029 invoked by uid 99); 27 Jun 2017 01:42:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 01:42:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 85828C242F; Tue, 27 Jun 2017 01:42:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.99 X-Spam-Level: ** X-Spam-Status: No, score=2.99 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sNgdU4z-czoG; Tue, 27 Jun 2017 01:42:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B33DB5FBEA; Tue, 27 Jun 2017 01:42:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 16824E00A0; Tue, 27 Jun 2017 01:42:20 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 56071C4034E; Tue, 27 Jun 2017 01:42:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5601456471836093139==" MIME-Version: 1.0 Subject: Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator. From: haosdent huang To: Jie Yu , haosdent huang , Vinod Kone , Jason Lai , Hao Yixin Cc: Gilbert Song , mesos Date: Tue, 27 Jun 2017 01:42:17 -0000 Message-ID: <20170627014217.8569.12930@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60170/ X-Sender: haosdent huang X-ReviewBoard-ShipIt: 1 References: <20170626223953.15286.33037@reviews-vm2.apache.org> In-Reply-To: <20170626223953.15286.33037@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: haosdent huang X-ReviewRequest-Repository: mesos archived-at: Tue, 27 Jun 2017 01:42:24 -0000 --===============5601456471836093139== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178943 ----------------------------------------------------------- Ship it! Ship It! - haosdent huang On June 26, 2017, 10:39 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60170/ > ----------------------------------------------------------- > > (Updated June 26, 2017, 10:39 p.m.) > > > Review request for mesos, haosdent huang, Hao Yixin, Jason Lai, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7691 > https://issues.apache.org/jira/browse/MESOS-7691 > > > Repository: mesos > > > Description > ------- > > This patch introduced a new agent isolation option 'cgroups', which > represents all local machine supported cgroup subsystems will be > turned on automatically. > > Note that if this 'cgroups' option is specified in isolation, all > other specified cgroup subsystems will be included. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp d7a95b2d49fd2ae743e2bffc25f15c4ce4b96f39 > > > Diff: https://reviews.apache.org/r/60170/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > > --===============5601456471836093139==--