Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AA43A200CA6 for ; Tue, 13 Jun 2017 10:29:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A8DCD160BDC; Tue, 13 Jun 2017 08:29:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F21DA160BC9 for ; Tue, 13 Jun 2017 10:29:20 +0200 (CEST) Received: (qmail 37002 invoked by uid 500); 13 Jun 2017 08:29:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 36991 invoked by uid 99); 13 Jun 2017 08:29:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jun 2017 08:29:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7F7611AF95B; Tue, 13 Jun 2017 08:29:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mB4MDD9qiXEC; Tue, 13 Jun 2017 08:29:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CBD8F5FCE2; Tue, 13 Jun 2017 08:29:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 241F0E00FE; Tue, 13 Jun 2017 08:29:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 85F4BC403F9; Tue, 13 Jun 2017 08:29:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0009513354276750751==" MIME-Version: 1.0 Subject: Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles. From: Michael Park To: Neil Conway , Benjamin Mahler Cc: Benjamin Bannier , Mesos Reviewbot Windows , Michael Park , mesos Date: Tue, 13 Jun 2017 08:29:15 -0000 Message-ID: <20170613082915.20633.62594@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Michael Park X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59860/ X-Sender: Michael Park References: <20170610014812.7068.90164@reviews-vm2.apache.org> In-Reply-To: <20170610014812.7068.90164@reviews-vm2.apache.org> Reply-To: Michael Park X-ReviewRequest-Repository: mesos archived-at: Tue, 13 Jun 2017 08:29:21 -0000 --===============0009513354276750751== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 9, 2017, 6:48 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 578-579 (patched) > > > > > > I wonder if we could have 0 initial delay by default for the tests so that you don't have to deal with this here. Want to file a ticket? :D Added https://issues.apache.org/jira/browse/MESOS-7657 and added you as a watcher. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59860/#review177534 ----------------------------------------------------------- On June 13, 2017, 1:22 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59860/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 1:22 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7633 > https://issues.apache.org/jira/browse/MESOS-7633 > > > Repository: mesos > > > Description > ------- > > Prevent allocating non-capable agents' resources to hierarchical roles. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp 73d0b42433a1ff3e853e851b8191864b4e233666 > src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 > > > Diff: https://reviews.apache.org/r/59860/diff/2/ > > > Testing > ------- > > New tests + `make check`. > > > Thanks, > > Michael Park > > --===============0009513354276750751==--