Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1582602534651152436=="
MIME-Version: 1.0
Subject: Re: Review Request 59782: Windows: Fixed curl build.
From: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
To: Li Li <lilyfang@hotmail.com>, Joseph Wu <joseph@mesosphere.io>,
 Jeff Coffler <jeff@taltos.com>
Cc: mesos <reviews@mesos.apache.org>
Date: Thu, 08 Jun 2017 22:09:17 -0000
Message-ID: <20170608220917.1777.80224@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Andrew Schwartzmeyer <noreply@reviews.apache.org>
References: <20170608211738.1778.13622@reviews-vm2.apache.org>
In-Reply-To: <20170608211738.1778.13622@reviews-vm2.apache.org>
Reply-To: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
archived-at: Thu, 08 Jun 2017 22:09:22 -0000

--===============1582602534651152436==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On June 8, 2017, 9:17 p.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 225-227 (patched)
> > <https://reviews.apache.org/r/59782/diff/1/?file=1741006#file1741006line225>
> >
> >     This was guarded in the other file, but why not here?
> >     
> >     Also, `curl.h` is only included in `stout/include/stout/net.hpp` at the moment, so it doesn't seem too hard to just address this TODO now.
> 
> Joseph Wu wrote:
>     Oh, I see that the flag was guarded in a later review: https://reviews.apache.org/r/59787/
>     
>     Second question still stands though.

> This was guarded in the other file, but why not here?

I must have messed up when rebasing, it should be guarded here too.

> Also, curl.h is only included in stout/include/stout/net.hpp at the moment, so it doesn't seem too hard to just address this TODO now.

Problem is that there is no `STOUT_CXX_FLAGS` since stout is just a bunch of headers we include willy-nilly... and this being CMake, the build system has no knowledge of who is using which header. Not saying this can't be done, but I gave it a go and decided to leave a TODO after failing ;)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59782/#review177381
-----------------------------------------------------------


On June 3, 2017, 7:33 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59782/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 7:33 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6814 and MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-6814
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of calling `msbuild` with hard-coded arguments, this instead
> uses the forwarded CMake arguments, and automatic `ExternalProject_Add`
> build.
> 
> The `-DCURL_STATIC_LIB` must be defined here so that every target which
> includes `glog.h` has the proper configuration.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
>   cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 
> 
> 
> Diff: https://reviews.apache.org/r/59782/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


--===============1582602534651152436==--