Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26EF8200CA8 for ; Thu, 1 Jun 2017 02:38:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 25559160BDB; Thu, 1 Jun 2017 00:38:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B8FA160BCB for ; Thu, 1 Jun 2017 02:38:15 +0200 (CEST) Received: (qmail 26860 invoked by uid 500); 1 Jun 2017 00:38:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26849 invoked by uid 99); 1 Jun 2017 00:38:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Jun 2017 00:38:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EEE7CC0C0B; Thu, 1 Jun 2017 00:38:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ut5BFEyTnZX4; Thu, 1 Jun 2017 00:38:12 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5D0EC5F5B4; Thu, 1 Jun 2017 00:38:12 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03C94E05F7; Thu, 1 Jun 2017 00:38:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D75B4C40414; Thu, 1 Jun 2017 00:38:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8542653497655935068==" MIME-Version: 1.0 Subject: Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`. From: Anindya Sinha To: Vinod Kone , Jiang Yan Xu , James Peach Cc: Anindya Sinha , mesos Date: Thu, 01 Jun 2017 00:38:11 -0000 Message-ID: <20170601003811.8717.24690@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57817/ X-Sender: Anindya Sinha References: <20170531145255.4296.12872@reviews-vm2.apache.org> In-Reply-To: <20170531145255.4296.12872@reviews-vm2.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos archived-at: Thu, 01 Jun 2017 00:38:16 -0000 --===============8542653497655935068== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ ----------------------------------------------------------- (Updated June 1, 2017, 12:38 a.m.) Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. Changes ------- Fixed merge conflict. Bugs: MESOS-7015 https://issues.apache.org/jira/browse/MESOS-7015 Repository: mesos Description ------- If the `SUBSCRIBE` indicates a subset of roles to be suppressed during framework (re)registration, the allocator does not offer resources for those roles to such frameworks. Note that this functionality is added for `v1::SUBSCRIBE` only (and not for scheduler driver API). In addition, the master validates the suppressed roles to be a subset of all the roles being (re)registered by the framework. Diffs (updated) ----- include/mesos/allocator/allocator.hpp b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d src/master/allocator/mesos/allocator.hpp b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 src/master/allocator/mesos/hierarchical.hpp 5e7c3068061012c51d4b9220dedf476408016a12 src/master/allocator/mesos/hierarchical.cpp 6679d47ea53bbcd68d375654edf6e85890e5772a src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe src/tests/hierarchical_allocator_tests.cpp eb2b647d3247a85e8b9b82e5589232c74ad8570f src/tests/master_allocator_tests.cpp 0082045ccaebe015725c5e178aa89dac32b1c50c src/tests/persistent_volume_endpoints_tests.cpp 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 src/tests/resource_offers_tests.cpp 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 src/tests/slave_recovery_tests.cpp e140f4d902a43b8fb2390541a357a217896b6228 Diff: https://reviews.apache.org/r/57817/diff/12/ Changes: https://reviews.apache.org/r/57817/diff/11-12/ Testing ------- All tests passed. Thanks, Anindya Sinha --===============8542653497655935068==--