mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60235: Linted support/test-upgrade.py.
Date Mon, 26 Jun 2017 09:59:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60235/#review178877
-----------------------------------------------------------


Fix it, then Ship it!





support/test-upgrade.py
Lines 34 (patched)
<https://reviews.apache.org/r/60235/#comment253183>

    Could we add a one-line, PEP257-conformant summary here, e.g.,
    
        """
        Helper class to keep track of process lifecycles.
    
        This class allows to i.e., start processes, capture their output,
        and checking their liveness during delays/sleep.
        """
    
    Also, add a blank line before declaring the first method.



support/test-upgrade.py
Lines 49 (patched)
<https://reviews.apache.org/r/60235/#comment253184>

    Let's add a PEP257-conformant summary line, e.g.,
    
            """
            Poll the process for the specified number of seconds.
    
            We return the process's return value if it ends during that
            time. Returns `True` if the process is still running after
            that time period.
            """



support/test-upgrade.py
Line 48 (original), 69 (patched)
<https://reviews.apache.org/r/60235/#comment253186>

    Add an empty line before declaring the first method.



support/test-upgrade.py
Line 60 (original), 79 (patched)
<https://reviews.apache.org/r/60235/#comment253187>

    Add an empty line before declaring the first method.



support/test-upgrade.py
Line 75 (original), 91 (patched)
<https://reviews.apache.org/r/60235/#comment253188>

    Add an empty line before declaring the first method.



support/test-upgrade.py
Lines 102-103 (original), 116-118 (patched)
<https://reviews.apache.org/r/60235/#comment253189>

    Let's fit this onto a single line, e.g.,
    
        """Convenience function to get the Mesos version from built executables."""



support/test-upgrade.py
Line 119 (original), 134 (patched)
<https://reviews.apache.org/r/60235/#comment253192>

    Let's add a one-line, PEP257-conformant summary, e.g.,
    
        Main function.



support/test-upgrade.py
Line 138 (original), 158 (patched)
<https://reviews.apache.org/r/60235/#comment253194>

    I think explicitly converting this `Boolean`s to `Boolean`s is pretty verbose, how about
    
        if not prev_version or not next_version:



support/test-upgrade.py
Line 176 (original), 196 (patched)
<https://reviews.apache.org/r/60235/#comment253195>

    Let's rely on the thruthiness of `sleep`'s return value, e.g.,
    
        if not prev_master.sleep(0.5):



support/test-upgrade.py
Line 183 (original), 203 (patched)
<https://reviews.apache.org/r/60235/#comment253196>

    Let's rely on the thruthiness of `sleep`'s return value, e.g.,
    
        if not prev_agent.sleep(0.5):


- Benjamin Bannier


On June 20, 2017, 12:16 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60235/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/60235/diff/1/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message