mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Tue, 20 Jun 2017 06:43:51 GMT


> On May 9, 2017, 8:54 p.m., Benjamin Mahler wrote:
> > Before you commit this, it would be great if you could test this (I can't tell how
you tested this from the testing done section), e.g.:
> > 
> > * Clicking on a link from the top level task page (state should already be loaded)
> > * Navigating directly to a valid URL (state should not be loaded yet)
> > * Navigating directly to an invalid URL (e.g. bad agent ID) (state should not be
loaded)
> > 
> > To make sure that these all work as you expect.

> Clicking on a link from the top level task page 

Works

> Navigating directly to a valid URL (state should not be loaded yet)

Works

> Navigating directly to an invalid URL (e.g. bad agent ID) (state should not be loaded)

Back to last page. It is expected.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/#review174374
-----------------------------------------------------------


On May 3, 2017, 4:15 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58872/
> -----------------------------------------------------------
> 
> (Updated May 3, 2017, 4:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-4992
>     https://issues.apache.org/jira/browse/MESOS-4992
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Open sandbox link in a new tab would fail since it depends on agents
> information loading finish. This patch fixes it by ensuring the agents
> information loaded first and then rerouting the sandbox request.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js a021962573d452de1581e6a7717016eac7d0cd85

> 
> 
> Diff: https://reviews.apache.org/r/58872/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message