mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58874: Stripped spaces between directory elements in WebUI.
Date Tue, 20 Jun 2017 03:45:46 GMT


> On May 11, 2017, 8:35 a.m., Tomasz Janiszewski wrote:
> > src/webui/master/static/browse.html
> > Lines 17-20 (original), 17-20 (patched)
> > <https://reviews.apache.org/r/58874/diff/3/?file=1710161#file1710161line17>
> >
> >     How about usign `<span>` here instead of list? Then `/` will be just visible
text and then copyalbe whitouth hacks with zero sized text.
> >     
> >     
> >     I haven't tested this but below code is what I think it could look like.
> >     ```
> >     <div class="breadcrunb">
> >       <span ng-repeat="dir in path.split('/')">
> >          <a href="#/agents/{{agent_id}}/browse?path={{
> >                 encodeURIComponent(path.split('/').slice(0, $index + 1).join('/'))
> >                 }}">
> >                     {{dir}}
> >          </a>
> >          <span>/</span>
> >       </span>
> >     </div>
> >     ```
> 
> Tomasz Janiszewski wrote:
>     I've tested following code. It looks similar
>     ```diff
>     
>     diff --git a/src/webui/master/static/browse.html b/src/webui/master/static/browse.html
>     index b984919..0594f81 100644
>     --- a/src/webui/master/static/browse.html
>     +++ b/src/webui/master/static/browse.html
>     @@ -11,14 +11,15 @@
>        </li>
>      </ol>
>     
>     -<ol class="breadcrumb">
>     -  <li ng-repeat="dir in path.split('/')">
>     -    <a href="#/agents/{{agent_id}}/browse?path={{
>     +<div class="breadcrumb">
>     +  <span ng-repeat="dir in path.split('/').slice(1)">
>     +    <a style="white-space: nowrap" href="#/agents/{{agent_id}}/browse?path={{
>                   encodeURIComponent(path.split('/').slice(0, $index + 1).join('/'))}}">
>     +      <span class="dir">/</span>
>            {{dir}}
>          </a>
>     -  </li>
>     -</ol>
>     +  </span>
>     +</div>
>     
>      <div class="alert alert-error hidden" id="alert">
>        <button class="close" data-dismiss="alert">×</button>
>     diff --git a/src/webui/master/static/css/mesos.css b/src/webui/master/static/css/mesos.css
>     index 9f3de54..21e3ef1 100644
>     --- a/src/webui/master/static/css/mesos.css
>     +++ b/src/webui/master/static/css/mesos.css
>     @@ -41,6 +41,11 @@
>        content: "/";
>      }
>     
>     +.dir {
>     +  padding: 0 5px 0 0;
>     +  color: #ccc;
>     +}
>     +
>      /*
>       * /BOOTSTRAP OVERRIDES
>       */
>     
>     ```

Hi, @janisz very sorry for the delay. I try this patch, but the spcaces is still there. Seems
didn't resolve our problem.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58874/#review174615
-----------------------------------------------------------


On June 20, 2017, 3:41 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58874/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 3:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Bugs: MESOS-7468
>     https://issues.apache.org/jira/browse/MESOS-7468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stripped spaces between directory elements in WebUI.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html b9849197227b06df348789a49348e2b5d4cfd2ae 
>   src/webui/master/static/css/mesos.css 9f3de5427071fc61d3791c4bc2a660368c2cd3c2 
> 
> 
> Diff: https://reviews.apache.org/r/58874/diff/4/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> strip_space.gif
>   https://reviews.apache.org/media/uploaded/files/2017/05/03/79afd0b1-5fb1-437c-a91c-732009af8fe3__strip_space.gif
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message