mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Review Request 60095: Add filtering feature for unversioned /master/slaves endpoint.
Date Wed, 14 Jun 2017 19:44:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60095/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone.


Bugs: MESOS-7630
    https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
-------

Add filtering feature for unversioned /master/slaves endpoint.

Specifically, we can use "/master/slaves?slave_id=[slave id]" to 
query the info for that slave. One thing to mention is that the 
format for the response is the same as before, thus we still have
two categories "slaves" and "recovered_slaves" in the response JSON


Diffs
-----

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 
  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/tests/master_tests.cpp 543c4a3afab818578c3124331a092cb1057776af 


Diff: https://reviews.apache.org/r/60095/diff/1/


Testing
-------

Passed "make check"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter=MasterTest.SlavesEndpointQuerySlave --gtest_repeat=1000
--gtest_break_on_failure"


Thanks,

Quinn Leng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message