mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60057: Made explicit that we dispatch to a process manager.
Date Tue, 13 Jun 2017 21:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60057/#review177806
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60057]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 13, 2017, 8:30 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60057/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This member function of 'ProcessManager' was capturing a 'this'
> pointer when dispatching to itself, but did not properly use 'defer'
> or 'dispatch'. While this pattern is usually suspect, it was safe here
> as we can be sure that the process manager lives long enough to safely
> invoke the created callback.
> 
> This patch removes the capture of 'this' and instead explicitly
> references the 'static process_manager' in the created callback to
> signal that we rely on external invariants.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 4ff7448d171f39dbb8cbb81dd9bed136ad43d62d 
> 
> 
> Diff: https://reviews.apache.org/r/60057/diff/1/
> 
> 
> Testing
> -------
> 
> * `make check` (Fedora 25 clang-trunk w/ optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message